Merged
Conversation
joseph-isaacs
changed the title
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/fix-fsst
branch
from
db1e46c to
7b3111a
Compare
CI docs check caught links to pub(crate) constants CODES_OFFSETS_SLOT and CODES_VALIDITY_SLOT in the public FSSTData doc comment. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.920x ➖ datafusion / vortex-file-compressed (0.920x ➖, 2↑ 0↓)
|
Contributor
File Sizes: PolarSignals Profiling
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.999x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.993x ➖, 0↑ 0↓)
datafusion / parquet (1.005x ➖, 0↑ 1↓)
datafusion / arrow (0.993x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.110x ❌, 0↑ 15↓)
duckdb / vortex-compact (1.059x ➖, 0↑ 6↓)
duckdb / parquet (1.061x ➖, 1↑ 4↓)
duckdb / duckdb (1.083x ➖, 0↑ 8↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVME
Totals:
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.000x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.016x ➖, 0↑ 0↓)
datafusion / parquet (1.010x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.093x ➖, 0↑ 4↓)
duckdb / vortex-compact (1.062x ➖, 0↑ 2↓)
duckdb / parquet (0.994x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMe
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.918x ➖, 32↑ 0↓)
datafusion / vortex-compact (0.896x ✅, 61↑ 3↓)
datafusion / parquet (0.926x ➖, 18↑ 0↓)
duckdb / vortex-file-compressed (0.986x ➖, 14↑ 7↓)
duckdb / vortex-compact (0.899x ✅, 43↑ 5↓)
duckdb / parquet (0.954x ➖, 6↑ 1↓)
duckdb / duckdb (0.967x ➖, 13↑ 8↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVME
Totals:
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.928x ➖, 2↑ 0↓)
datafusion / vortex-compact (1.128x ➖, 0↑ 2↓)
datafusion / parquet (0.889x ➖, 4↑ 0↓)
duckdb / vortex-file-compressed (1.038x ➖, 1↑ 0↓)
duckdb / vortex-compact (1.084x ➖, 0↑ 1↓)
duckdb / parquet (1.089x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.966x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.952x ➖, 0↑ 0↓)
datafusion / parquet (1.018x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.981x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.984x ➖, 0↑ 0↓)
duckdb / parquet (0.992x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.916x ➖ unknown / unknown (1.015x ➖, 7↑ 11↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.045x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.041x ➖, 0↑ 1↓)
duckdb / parquet (1.028x ➖, 0↑ 1↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population Genetics
Totals:
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
File Sizes: Clickbench on NVME
Totals:
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: CompressionVortex (geomean): 0.998x ➖ unknown / unknown (0.994x ➖, 8↑ 4↓)
|
joseph-isaacs
changed the title
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Merging this PR will degrade performance by 14.72%
Performance Changes
Comparing 
Footnotes
|
robert3005
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FSST arrays used to have a children that MUST be a VarBin. However this doesn't work with slots.
Instead the FSST array has a offsets child and a bytes buffer.
This is not a break its backwards compat